replay: onboarding specific per sdk #7883
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/platform-includes/session-replay/install/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
| ```bash {tabTitle:Angular} | ||
| # npm | ||
| npm install --save @sentry/capacitor @sentry/angular-ivy @sentry/replay | ||
|
|
||
| # yarn | ||
| yarn add @sentry/capacitor @sentry/angular-ivy @sentry/replay | ||
| ``` |
There was a problem hiding this comment.
does the user need to install @sentry/replay if they're already doing @sentry/angular-ivy or @sentry/vue or whatever the framework is?
There was a problem hiding this comment.
cc @lucas-zimerman ^
| ```bash {tabTitle:Other Frameworks} | ||
| # npm | ||
| npm install --save @sentry/capacitor @sentry/replay | ||
|
|
||
| # yarn | ||
| yarn add @sentry/capacitor @sentry/replay | ||
| ``` |
There was a problem hiding this comment.
similar to above, should this be @sentry/capacitor @sentry/javascript?
There was a problem hiding this comment.
capacitor isn't part of the monorepo so I'm not sure if the re-export done works, but possibly so. I'll check and update on a follow up PR
There was a problem hiding this comment.
cc @lucas-zimerman ^
There was a problem hiding this comment.
this file is copy+pasted a few times (9 times). I didn't notice any errors with that, but idk if we can or should de-dupe it to make maintenance easier.
note that nextjs and remix and sveltekit have little headers at the top of the files which are nice to keep: "On your client-side NextJS app, add:"
There was a problem hiding this comment.
Hmmm yeah there is some duplication. We could pull both code snippets out into their own components, but I'm not sure it's worth the extra complexity here.
There was a problem hiding this comment.
Hmmm yeah there is some duplication. We could pull both code snippets out into their own components, but I'm not sure it's worth the extra complexity here.
| // If the entire session is not sampled, use the below sample rate to sample | ||
| // sessions when an error occurs. |
There was a problem hiding this comment.
I know this is just copied from existing docs, but this comment is confusing. This makes it sound like if you're setting replaysSessionSampleRate to 1.0 you can downsample errors with replaysSessionSampleRate, which is the opposite of the usual use case, right?
There was a problem hiding this comment.
Sorry i don't see how this phrase makes it sound like it's 1.0 (also the actual value is right above it so unlikely confusing)?
That said: happy to change these comments to something that makes more sense. Due to all the copy paste we'd need a find/replace. Best as a follow up PR
src/platform-includes/session-replay/install/javascript.nextjs.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/session-replay/install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/session-replay/install/javascript.sveltekit.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Resolves: #7045