Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replay: onboarding specific per sdk #7883
replay: onboarding specific per sdk #7883
Changes from 5 commits
91171b7
ac2bca0
7bfaf24
fce4f85
30e098f
f7d3dd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the user need to install
@sentry/replay
if they're already doing@sentry/angular-ivy
or@sentry/vue
or whatever the framework is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lucas-zimerman ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is copy+pasted a few times (9 times). I didn't notice any errors with that, but idk if we can or should de-dupe it to make maintenance easier.
note that nextjs and remix and sveltekit have little headers at the top of the files which are nice to keep: "On your client-side NextJS app, add:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm yeah there is some duplication. We could pull both code snippets out into their own components, but I'm not sure it's worth the extra complexity here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just copied from existing docs, but this comment is confusing. This makes it sound like if you're setting
replaysSessionSampleRate
to 1.0 you can downsample errors withreplaysSessionSampleRate
, which is the opposite of the usual use case, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry i don't see how this phrase makes it sound like it's 1.0 (also the actual value is right above it so unlikely confusing)?
That said: happy to change these comments to something that makes more sense. Due to all the copy paste we'd need a find/replace. Best as a follow up PR