Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for v8.2.0 #12073

Merged
merged 14 commits into from
May 16, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented May 16, 2024

Waiting on #12070

mydea and others added 12 commits May 16, 2024 09:51
This tests a node app that uses ESM, but no `--import` flag.
Somehow this works for `http` (but not other packages...) but this is
fine for errors-only mode, for now.

Missing: We do show the warning for missing express instrumentation
there, still 😬 we may need to tweak this...
Closes #12051

This PR does two things:

1. Ensures we add helpful attributes to idle spans more consistently. We
now add the `sentry.idle_span_finish_reason` attribute always for idle
spans, not only when op == `ui.action.click`. This should also make it
easier to debug stuff etc, and I see no reason to not always set this.
Additionally, we also keep the number of spans we discarded (if any) for
easier debugging too (as `sentry.idle_span_discarded_spans`).
2. We ensure that idle spans cannot exceed the configured
`finalTimeout`. Previously, due to the order of things, it was possible
that we ended a span very late, if it had a child span with a very late
end timestamp (as we took the last child span timestamp). Possibly this
could lead to overly long transactions.

I think 2, combined with the fact that later we _do_ filter out child
spans that ended after idle span, lead to the incorrect-length spans.
ref #12034

cc @AbhiPrasad when you're back, let's look again at
`hasTracingEnabled()` and see if we want to adjust this maybe.
In some places we used `Date.now()`, instead of `timestampInSeconds()`
which used performance.now().

There are still other places where we use `Date.now()`, esp. in replay
and node, but I focused on regular browser stuff for now (because this
is most likely to be affected by this).
…ble (#12066)

This is a bit weird in that we access the current scope & client etc.,
even if options are passed. Since we also use this method in `init()`
before we have setup stuff, it seems safer to avoid calling this at all
if possible.

This is related to
#12054, but not
really the cause of it.
[Gitflow] Merge master into develop
To make interop with e.g. importing `Scope` from `@sentry/node` easier.

Closes #12053
Actually we should check for the changelog commit, which we look for by
checking `-meta` and `changelog` in the commit message. (Not perfect,
but good enough hopefully...)

I noticed it was not correctly picking up all commits while a release
was in progress before.
…#12071)

We noticed that in http integration, we were only setting
`transactionName` when we had a sampled span. We can actually set this
based on the request object we get either way, making this more robust
for error-only mode.
…ource maps generation (#12072)

Now we can at least recommend to use `filesToDeleteAfterUpload` since we
bumped to vite plugin 2.x with 8.0.0
As discussed internally in Slack and #12006, we decided to remove
`interactionsSampleRate` from v8 for good (it never was added in a
publicly released `8.0.0*` version). This PR now updates the migration
guide to retroactively reflect this change.

closes #12006
@mydea mydea self-assigned this May 16, 2024
…ands) (#12070)

Populates the OTel span with cache attributes. Currently, `get` and
`set` commands are considered.

---------

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
@mydea mydea marked this pull request as ready for review May 16, 2024 14:36
@mydea mydea changed the base branch from develop to master May 16, 2024 14:38
@mydea mydea merged commit 0ef0c7f into master May 16, 2024
28 checks passed
@mydea mydea deleted the prepare-release/8.2.0 branch May 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants