Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for v8.2.0 #12073

Merged
merged 14 commits into from
May 16, 2024
Merged

Commits on May 16, 2024

  1. test(node): Add test for errors-only ESM app (#12046)

    This tests a node app that uses ESM, but no `--import` flag.
    Somehow this works for `http` (but not other packages...) but this is
    fine for errors-only mode, for now.
    
    Missing: We do show the warning for missing express instrumentation
    there, still 😬 we may need to tweak this...
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    89377da View commit details
    Browse the repository at this point in the history
  2. feat(browser): Improve idle span handling (#12065)

    Closes #12051
    
    This PR does two things:
    
    1. Ensures we add helpful attributes to idle spans more consistently. We
    now add the `sentry.idle_span_finish_reason` attribute always for idle
    spans, not only when op == `ui.action.click`. This should also make it
    easier to debug stuff etc, and I see no reason to not always set this.
    Additionally, we also keep the number of spans we discarded (if any) for
    easier debugging too (as `sentry.idle_span_discarded_spans`).
    2. We ensure that idle spans cannot exceed the configured
    `finalTimeout`. Previously, due to the order of things, it was possible
    that we ended a span very late, if it had a child span with a very late
    end timestamp (as we took the last child span timestamp). Possibly this
    could lead to overly long transactions.
    
    I think 2, combined with the fact that later we _do_ filter out child
    spans that ended after idle span, lead to the incorrect-length spans.
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    ccb98ff View commit details
    Browse the repository at this point in the history
  3. fix(node): Fix check for performance integrations (#12043)

    ref #12034
    
    cc @AbhiPrasad when you're back, let's look again at
    `hasTracingEnabled()` and see if we want to adjust this maybe.
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    d634385 View commit details
    Browse the repository at this point in the history
  4. fix(browser): Use consistent timestamps (#12063)

    In some places we used `Date.now()`, instead of `timestampInSeconds()`
    which used performance.now().
    
    There are still other places where we use `Date.now()`, esp. in replay
    and node, but I focused on regular browser stuff for now (because this
    is most likely to be affected by this).
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    677602f View commit details
    Browse the repository at this point in the history
  5. fix(core): Avoid looking up client for hasTracingEnabled() if possi…

    …ble (#12066)
    
    This is a bit weird in that we access the current scope & client etc.,
    even if options are passed. Since we also use this method in `init()`
    before we have setup stuff, it seems safer to avoid calling this at all
    if possible.
    
    This is related to
    #12054, but not
    really the cause of it.
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    07c6838 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #12068 from getsentry/master

    [Gitflow] Merge master into develop
    github-actions[bot] authored May 16, 2024
    Configuration menu
    Copy the full SHA
    4b18edd View commit details
    Browse the repository at this point in the history
  7. fix(core): Export Scope interface as Scope (#12067)

    To make interop with e.g. importing `Scope` from `@sentry/node` easier.
    
    Closes #12053
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    4a1f2ac View commit details
    Browse the repository at this point in the history
  8. meta: Fix changelog script (#12069)

    Actually we should check for the changelog commit, which we look for by
    checking `-meta` and `changelog` in the commit message. (Not perfect,
    but good enough hopefully...)
    
    I noticed it was not correctly picking up all commits while a release
    was in progress before.
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    4003f7e View commit details
    Browse the repository at this point in the history
  9. fix(node): Set transactionName for unsampled spans in httpIntegration (

    …#12071)
    
    We noticed that in http integration, we were only setting
    `transactionName` when we had a sampled span. We can actually set this
    based on the request object we get either way, making this more robust
    for error-only mode.
    mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    c594d6a View commit details
    Browse the repository at this point in the history
  10. ref(sveltekit): Warn to delete source maps if Sentry plugin enabled s…

    …ource maps generation (#12072)
    
    Now we can at least recommend to use `filesToDeleteAfterUpload` since we
    bumped to vite plugin 2.x with 8.0.0
    Lms24 authored May 16, 2024
    Configuration menu
    Copy the full SHA
    bc29d88 View commit details
    Browse the repository at this point in the history
  11. doc(migration): Add entry for interactionsSampleRate (#12064)

    As discussed internally in Slack and #12006, we decided to remove
    `interactionsSampleRate` from v8 for good (it never was added in a
    publicly released `8.0.0*` version). This PR now updates the migration
    guide to retroactively reflect this change.
    
    closes #12006
    Lms24 authored May 16, 2024
    Configuration menu
    Copy the full SHA
    6c37df1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f1d1a16 View commit details
    Browse the repository at this point in the history
  13. feat(redis-cache): Create cache-span with prefixed keys (get/set comm…

    …ands) (#12070)
    
    Populates the OTel span with cache attributes. Currently, `get` and
    `set` commands are considered.
    
    ---------
    
    Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
    s1gr1d and mydea authored May 16, 2024
    Configuration menu
    Copy the full SHA
    257bcb0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    46511e5 View commit details
    Browse the repository at this point in the history