Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nextjs): Pin Nextjs 13 integration tests to next@13.4.9 #8551

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 17, 2023

As long as our SDK and next@13.4.10 aren't compatible, we need to hard-pin our NextJS integration tests to 13.4.9 to unblock our CI.

We need to revert this PR once we figured out 13.4.10! (Set a reminder for myself)

ref #8541

@Lms24 Lms24 changed the title test(nextjs): Pin Nextjs 13 integration tests to 13.4.9 test(nextjs): Pin Nextjs 13 integration tests to next@13.4.9 Jul 17, 2023
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? just to clarify

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, don't even know how this got in here... probably because I ran the tests locally. Will remove, thanks!

@Lms24 Lms24 marked this pull request as ready for review July 17, 2023 11:24
@Lms24 Lms24 enabled auto-merge (squash) July 17, 2023 11:24
@Lms24 Lms24 merged commit 69a4fa3 into develop Jul 17, 2023
@Lms24 Lms24 deleted the lms/fix-nextjs-integraiton-tests-broken branch July 17, 2023 11:38
Lms24 added a commit that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants