Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(nextjs): Pin Nextjs 13 integration tests to next@13.4.9 #8551

Merged
merged 2 commits into from
Jul 17, 2023
Merged

test(nextjs): Pin Nextjs 13 integration tests to next@13.4.9 #8551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a0b1f
test(nextjs): Pin nextjs13 integration tests to 13.4.9
Lms24 Jul 17, 2023
df9bdf9
Update packages/nextjs/test/integration/next-env.d.ts
Lms24 Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/nextjs/test/integration/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? just to clarify

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, don't even know how this got in here... probably because I ran the tests locally. Will remove, thanks!

Lms24 marked this conversation as resolved.
Show resolved Hide resolved

// NOTE: This file should not be edited
// see https://nextjs.org/docs/basic-features/typescript for more information.
12 changes: 10 additions & 2 deletions packages/nextjs/test/run-integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,21 @@ for NEXTJS_VERSION in 10 11 12 13; do
rm -rf node_modules .next .env.local 2>/dev/null || true

echo "[nextjs@$NEXTJS_VERSION] Installing dependencies..."

# set the desired version of next long enough to run yarn, and then restore the old version (doing the restoration now
# rather than during overall cleanup lets us look for "latest" in every loop)

if [ "$NEXTJS_VERSION" -eq "13" ]; then
SPECIFIC_NEXT_VERSION="13.4.9"
else
SPECIFIC_NEXT_VERSION="$NEXTJS_VERSION.x"
fi

cp package.json package.json.bak
if [[ $(uname) == "Darwin" ]]; then
sed -i "" /"next.*latest"/s/latest/"${NEXTJS_VERSION}.x"/ package.json
sed -i "" /"next.*latest"/s/latest/"${SPECIFIC_NEXT_VERSION}"/ package.json
else
sed -i /"next.*latest"/s/latest/"${NEXTJS_VERSION}.x"/ package.json
sed -i /"next.*latest"/s/latest/"${SPECIFIC_NEXT_VERSION}"/ package.json
fi

# Next.js v13 requires React 18.2.0
Expand Down