Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Add more codeowners #200

Merged
merged 3 commits into from
Jan 8, 2024
Merged

ref: Add more codeowners #200

merged 3 commits into from
Jan 8, 2024

Conversation

untitaker
Copy link
Member

Pierre should not be blocked on changes to the schema, he sufficiently
owns both ends of the pipe

Pierre should not be blocked on changes to the schema, he sufficiently
owns both ends of the pipe
@untitaker untitaker requested a review from a team as a code owner January 8, 2024 17:42
@phacops
Copy link
Contributor

phacops commented Jan 8, 2024

I would love more access like this. I would also include:

  • metrics_summaries (@getsentry/performance)
  • spans (@getsentry/performance)
  • profiles (@getsentry/profiling)
  • functions (@getsentry/profiling)

Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owners-snuba should still be on this like all other snuba topics

CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Lyn Nagara <lyn.nagara@gmail.com>
@untitaker
Copy link
Member Author

it's not clear to me why we have codeowners for the topic yaml inconsistent with the examples and schema file. IMO those all should be the same

@untitaker untitaker changed the title ref(spans): Make PDPM the sole codeowner for spans ref: Add more codeowners Jan 8, 2024
@untitaker untitaker merged commit 7a7e4cd into main Jan 8, 2024
15 checks passed
@untitaker untitaker deleted the ref/spans-codeowner branch January 8, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants