Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Add more codeowners #200

Merged
merged 3 commits into from
Jan 8, 2024
Merged

ref: Add more codeowners #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4139a23
ref(spans): Make PDPM the sole codeowner for spans
untitaker Jan 8, 2024
d30f80c
Update CODEOWNERS
untitaker Jan 8, 2024
8e23806
add more codeowners
untitaker Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,24 @@
/topics/processed-profiles.yaml @getsentry/owners-snuba @getsentry/profiling
/topics/profiles-call-tree.yaml @getsentry/owners-snuba @getsentry/profiling
/topics/group-attributes.yaml @getsentry/owners-snuba @getsentry/issues
/topics/snuba-spans.yaml @getsentry/owners-snuba
/topics/snuba-spans.yaml @getsentry/owners-snuba @getsentry/profiling

# Topics produced to by Snuba
/topics/shared-resources-usage.yaml @getsentry/owners-snuba @getsentry/data

# Schemas
/schemas/profile-metadata.v1.schema.json @getsentry/profiling
/schemas/profile-functions.v1.schema.json @getsentry/profiling
/schemas/group-attributes.v1.schema.json @getsentry/issues
/schemas/profile-metadata.v1.schema.json @getsentry/owners-snuba @getsentry/profiling
/schemas/profile-functions.v1.schema.json @getsentry/owners-snuba @getsentry/profiling
/schemas/group-attributes.v1.schema.json @getsentry/owners-snuba @getsentry/issues
/schemas/ingest-spans.v1.schema.json @getsentry/team-starfish
/schemas/snuba-spans.v1.schema.json @getsentry/owners-snuba @getsentry/profiling

# Examples
/examples/profile-metadata/ @getsentry/profiling
/examples/profile-functions/ @getsentry/profiling
/examples/group-attributes/ @getsentry/issues
/examples/ingest-spans/ @getsentry/team-starfish
/examples/profile-metadata/ @getsentry/owners-snuba @getsentry/profiling
/examples/profile-functions/ @getsentry/owners-snuba @getsentry/profiling
/examples/group-attributes/ @getsentry/owners-snuba @getsentry/issues
/examples/ingest-spans/ @getsentry/owners-snuba @getsentry/team-starfish
/examples/snuba-spans/ @getsentry/owners-snuba @getsentry/profiling

# Internal Snuba topics
/topics/snuba-queries.yaml @getsentry/owners-snuba
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,5 @@ command is `make install-py-dev`.

All topics definitions, schemas and examples should have a defined owner or multiple owners if shared.
The CODEOWNERS file should be updated with this information whenever new schemas and topics are added.

Review is only required from one team/owner, not from all of them.
Loading