fix(CI): Treat skipped test jobs as failed #2553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
check-permissionscheck fails, the dependent test step will be skipped. The step that actually checks whether a test job was successful only checks for failures, so skipped test jobs are treated as successful, which shouldn't be the case.So for example in the case of the AWS Lambda suite running on a contributor PR without the
Trigger: tests using secretslabel, the permissions check will be a failure, so the actual Lambda tests will be skipped, but the overall "All AWS Lambda tests were successful" check will still be green because technically there were no failures.With this PR we also consider skipped test steps as an overall failure.