Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Treat skipped test jobs as failed #2553

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All common tests passed or skipped
name: All common tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-aiohttp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All aiohttp tests passed or skipped
name: All aiohttp tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-ariadne.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All ariadne tests passed or skipped
name: All ariadne tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-arq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All arq tests passed or skipped
name: All arq tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-asgi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All asgi tests passed or skipped
name: All asgi tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-asyncpg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All asyncpg tests passed or skipped
name: All asyncpg tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-aws_lambda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All aws_lambda tests passed or skipped
name: All aws_lambda tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-beam.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All beam tests passed or skipped
name: All beam tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-boto3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All boto3 tests passed or skipped
name: All boto3 tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-bottle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All bottle tests passed or skipped
name: All bottle tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-celery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All celery tests passed or skipped
name: All celery tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-chalice.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All chalice tests passed or skipped
name: All chalice tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-clickhouse_driver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All clickhouse_driver tests passed or skipped
name: All clickhouse_driver tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-cloud_resource_context.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All cloud_resource_context tests passed or skipped
name: All cloud_resource_context tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-django.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,17 +187,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All django tests passed or skipped
name: All django tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-falcon.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All falcon tests passed or skipped
name: All falcon tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-fastapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All fastapi tests passed or skipped
name: All fastapi tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-flask.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All flask tests passed or skipped
name: All flask tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All gcp tests passed or skipped
name: All gcp tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/test-integration-gevent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,17 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All gevent tests passed or skipped
name: All gevent tests passed
needs: [test-pinned, test-py27]
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
- name: Check for 2.7 failures
if: contains(needs.test-py27.result, 'failure')
if: contains(needs.test-py27.result, 'failure') || contains(needs.test-py27.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-gql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All gql tests passed or skipped
name: All gql tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
4 changes: 2 additions & 2 deletions .github/workflows/test-integration-graphene.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
check_required_tests:
name: All graphene tests passed or skipped
name: All graphene tests passed
needs: test-pinned
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test-pinned.result, 'failure')
if: contains(needs.test-pinned.result, 'failure') || contains(needs.test-pinned.result, 'skipped')
run: |
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
Loading
Loading