Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update actions/upload-artifact to v4 #1749

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

joshuarli
Copy link
Member

bitsandfoxes
bitsandfoxes previously approved these changes Jul 31, 2024
@joshuarli
Copy link
Member Author

joshuarli commented Jul 31, 2024

will need to take a closer look at how package-release.zip makes its way to github releases, might be depending on artifact name (which needs to change along with download-artifact)

edit: see getsentry/craft#552

@bitsandfoxes
Copy link
Contributor

I don't think this has anything to do with craft but with https://github.com/vaind/download-artifact forking v2

@vaind
Copy link
Collaborator

vaind commented Aug 15, 2024

I don't think this has anything to do with craft but with vaind/download-artifact forking v2

I haven't been tagged here so only now noticed this by accident. Here's an updated version of the download action & I've pushed a commit to this branch to try & fix CI

@vaind vaind changed the title all-repos: update actions/upload-artifact to v4 deps: update actions/upload-artifact to v4 Aug 15, 2024
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaind, that works!

@bitsandfoxes bitsandfoxes merged commit 711c00d into main Aug 16, 2024
123 of 124 checks passed
@bitsandfoxes bitsandfoxes deleted the all-repos_autofix_all-repos-sed branch August 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants