deps: update actions/upload-artifact to v4

.github/workflows/android-smoke-test.yml

@@ -34,7 +34,7 @@ jobs:
  uses: actions/checkout@v3
 
  - name: Download test app artifact
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: testapp-Android-compiled-${{ inputs.unity-version }}
  path: samples/IntegrationTest/Build
@@ -85,7 +85,7 @@ jobs:
 
  - name: Upload artifacts on failure
  if: ${{ failure() }}
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: testapp-android-logs-${{ inputs.api-level }}-${{ inputs.unity-version }}-${{ inputs.try }}
  path: ${{ env.ARTIFACTS_PATH }}

.github/workflows/ci.yml

@@ -3,8 +3,8 @@ name: CI
 on:
  push:
  paths-ignore:
- - '**.md'
- - '**.txt'
+ - "**.md"
+ - "**.txt"
  workflow_dispatch: # e.g. to manually trigger on foreign PRs
 
 env:
@@ -53,7 +53,7 @@ jobs:
  fail-fast: false
  matrix:
  # Building the SDK with Unity 2022 requires ns2.1 - skipping for now
- unity-version: ['2019', '2020', '2021']
+ unity-version: ["2019", "2020", "2021"]
  steps:
  - name: Checkout
  uses: actions/checkout@v3
@@ -88,37 +88,37 @@ jobs:
  - name: Download CLI
  run: ./scripts/download-sentry-cli.ps1
 
- - uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ - uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: Android-sdk
  path: package-dev/Plugins/Android
  wait-timeout: 3600
 
- - uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ - uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: Android-libraries
  path: modules/sentry-java/sentry-android-ndk/build/intermediates/merged_native_libs/release/out/lib
  wait-timeout: 3600
 
- - uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ - uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: iOS-sdk
  path: package-dev/Plugins/iOS
  wait-timeout: 3600
 
- - uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ - uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: macOS-sdk
  path: package-dev/Plugins/macOS
  wait-timeout: 3600
 
- - uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ - uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: Linux-sdk
  path: package-dev/Plugins/Linux
  wait-timeout: 3600
 
- - uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ - uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: Windows-sdk
  path: package-dev/Plugins/Windows
@@ -145,7 +145,7 @@ jobs:
  ./scripts/pack.ps1
 
  - name: Upload release artifacts
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  if: ${{ matrix.unity-version == env.LOWEST_SUPPORTED_UNITY_VERSION }}
  with:
  name: ${{ github.sha }}
@@ -162,7 +162,7 @@ jobs:
 
  - name: Upload test artifacts (playmode)
  if: ${{ failure() }}
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: Test results (playmode)
  path: artifacts/test/playmode
@@ -172,7 +172,7 @@ jobs:
 
  - name: Upload test artifacts (editmode)
  if: ${{ failure() }}
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: Test results (editmode)
  path: artifacts/test/editmode
@@ -185,7 +185,7 @@ jobs:
  uses: actions/checkout@v3
 
  - name: Download UPM package
- uses: vaind/download-artifact@cbec071ac01e26699bc70c82f63ef724b3b0a91d
+ uses: vaind/download-artifact@e7141b6a94ef28aa3d828b52830cfa1f406a1848
  with:
  name: ${{ github.sha }}
  wait-timeout: 3600
@@ -209,7 +209,7 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- unity-version: ['2019', '2020', '2021', '2022']
+ unity-version: ["2019", "2020", "2021", "2022"]
  env:
  UNITY_PATH: docker exec unity unity-editor
  steps:
@@ -227,7 +227,7 @@ jobs:
 
  - name: Download UPM package
  if: ${{ github.ref_name != 'main' }}
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: ${{ github.sha }}
 
@@ -244,7 +244,7 @@ jobs:
  run: tar -cvzf test-project.tar.gz samples/IntegrationTest
 
  - name: Upload project
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: smoke-test-${{ matrix.unity-version }}
  if-no-files-found: error
@@ -261,11 +261,11 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- unity-version: ['2019', '2020', '2021', '2022']
- platform: ['Android', 'WebGL', 'Linux', 'iOS']
+ unity-version: ["2019", "2020", "2021", "2022"]
+ platform: ["Android", "WebGL", "Linux", "iOS"]
  include:
  - platform: Linux
- image-suffix: '-il2cpp'
+ image-suffix: "-il2cpp"
  env:
  UNITY_PATH: docker exec unity unity-editor
  steps:
@@ -280,7 +280,7 @@ jobs:
  haskell: true
  large-packages: false
  docker-images: false
- swap-storage: true 
+ swap-storage: true
 
  - run: echo "::add-mask::${{ secrets.LICENSE_SERVER_URL }}"
 
@@ -297,7 +297,7 @@ jobs:
  docker exec --user root unity apt-get -y -q install mono-devel
 
  - name: Download IntegrationTest project
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: smoke-test-${{ matrix.unity-version }}
 
@@ -310,7 +310,7 @@ jobs:
  run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform "${{ matrix.platform }}"
 
  - name: Download UPM package
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: ${{ github.sha }}
 
@@ -353,7 +353,7 @@ jobs:
  tar -cvzf test-app.tar.gz samples/IntegrationTest/Build
 
  - name: Upload test app
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: testapp-${{ matrix.platform }}-${{ matrix.unity-version }}
  if-no-files-found: error
@@ -363,7 +363,7 @@ jobs:
 
  - name: Upload IntegrationTest project on failure
  if: ${{ failure() }}
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: failed-project-${{ matrix.platform }}-${{ matrix.unity-version }}
  path: |
@@ -380,8 +380,8 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- unity-version: ['2019', '2020', '2021', '2022']
- os: ['windows', 'macos']
+ unity-version: ["2019", "2020", "2021", "2022"]
+ os: ["windows", "macos"]
  include:
  - os: windows
  unity-modules: windows-il2cpp
@@ -411,7 +411,7 @@ jobs:
  Set-Content -Path '${{ matrix.unity-config-path }}services-config.json' -Value '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
 
  - name: Download IntegrationTest project
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: smoke-test-${{ matrix.unity-version }}
 
@@ -424,7 +424,7 @@ jobs:
  run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${{ env.UNITY_PATH }}"
 
  - name: Download UPM package
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: ${{ github.sha }}
 
@@ -459,18 +459,18 @@ jobs:
  fail-fast: false
  matrix:
  api-level: [27, 28, 29, 30, 31] # last updated October 2022
- unity-version: ['2019', '2020', '2021', '2022']
+ unity-version: ["2019", "2020", "2021", "2022"]
  include:
  # API 21 is barely used but let's check it as the minimum supported version for now.
  - api-level: 21
- unity-version: '2019'
+ unity-version: "2019"
  exclude:
  # Seems like there's an error in Unity with Android API 30 - disabling.
  # https://github.com/getsentry/sentry-unity/issues/719#issuecomment-1129129952
  - api-level: 30
- unity-version: '2021'
+ unity-version: "2021"
  - api-level: 30
- unity-version: '2022'
+ unity-version: "2022"
 
  mobile-smoke-test-compile:
  if: ${{ !startsWith(github.ref, 'refs/heads/release/') }}
@@ -480,24 +480,24 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- unity-version: ['2019', '2020', '2021', '2022']
- platform: ['Android', 'iOS']
+ unity-version: ["2019", "2020", "2021", "2022"]
+ platform: ["Android", "iOS"]
  include:
  # See supported version in https://docs.unity3d.com/2022.2/Documentation/Manual/android-sdksetup.html
- - unity-version: '2019'
- ndk: 'r19'
- - unity-version: '2020'
- ndk: 'r19'
- - unity-version: '2021'
- ndk: 'r21d'
- - unity-version: '2022'
- ndk: 'r21d'
+ - unity-version: "2019"
+ ndk: "r19"
+ - unity-version: "2020"
+ ndk: "r19"
+ - unity-version: "2021"
+ ndk: "r21d"
+ - unity-version: "2022"
+ ndk: "r21d"
  steps:
  - name: Checkout
  uses: actions/checkout@v3
 
  - name: Download app project
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: testapp-${{ matrix.platform }}-${{ matrix.unity-version }}
 
@@ -534,7 +534,7 @@ jobs:
  ./scripts/smoke-test-${{ matrix.platform == 'iOS' && 'ios' || 'android' }}.ps1 Build -IsIntegrationTest -UnityVersion "${{ matrix.unity-version }}"
 
  - name: Upload app
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: testapp-${{ matrix.platform }}-compiled-${{ matrix.unity-version }}
  # Collect app but ignore the files that are not required for the test.
@@ -554,24 +554,24 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- unity-version: ['2019', '2020', '2021', '2022']
+ unity-version: ["2019", "2020", "2021", "2022"]
  # Check https://support.apple.com/en-us/HT201222 for the latest minor version for a given major one.
- # https://developer.apple.com/support/app-store/ shows that of all iOS devices 
+ # https://developer.apple.com/support/app-store/ shows that of all iOS devices
  # - `iOS 16`: 71%
  # - `iOS 15`: 20 %
  # - the rest: 8 %
  # as of May 2, 2023. Therefore, let's stick to testing iOS 15 and `latest` for now.
  # Numbers as string otherwise GH will reformat the runtime numbers removing the fractions.
  # Also make sure to match the versions available here:
  # - https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
- ios: ['15.4', latest] # last updated May 2023
+ ios: ["15.4", latest] # last updated May 2023
 
  steps:
  - name: Checkout
  uses: actions/checkout@v3
 
  - name: Download app artifact
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: testapp-iOS-compiled-${{ matrix.unity-version }}
  path: samples/IntegrationTest/Build
@@ -609,14 +609,14 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- unity-version: ['2019', '2020', '2021', '2022']
- platform: ['WebGL', 'Linux']
+ unity-version: ["2019", "2020", "2021", "2022"]
+ platform: ["WebGL", "Linux"]
  steps:
  - name: Checkout
  uses: actions/checkout@v3
 
  - name: Download test app artifact
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  id: download
  with:
  name: testapp-${{ matrix.platform }}-${{ matrix.unity-version }}
@@ -637,4 +637,4 @@ jobs:
 
  - name: Run Crash Test (Linux)
  if: ${{ matrix.platform == 'Linux' }}
- run: ./test/Scripts.Integration.Test/run-smoke-test.ps1 -Crash
+ run: ./test/Scripts.Integration.Test/run-smoke-test.ps1 -Crash

.github/workflows/sdk.yml

@@ -66,20 +66,20 @@ jobs:
 
  - name: Upload build logs on failure
  if: ${{ failure() }}
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  path: ${{ steps.env.outputs.submodulesPath }}/build.log
  # Lower retention period - we only need this to retry CI.
  retention-days: 14
 
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
  with:
  name: ${{ inputs.target }}-sdk
  path: package-dev/Plugins/${{ inputs.target }}
  # Lower retention period - we only need this to retry CI.
  retention-days: 14
 
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
  if: ${{ inputs.target == 'Android' }}
  with:
  name: ${{ inputs.target }}-libraries