ref: Make eventstore.processing use LazyServiceWrapper

[untitaker]

LazyServiceWrapper is a horrible old beast but it has a few sanity
checks that a simple import_string lacks. For starters, whether the
imported string even implements the relevant service baseclass.

Also LazyServiceWrapper supports typing now (which is the trigger
for doing this), while import_string would require one additional type
hint. That's easy to add but I don't particularly care for having N
ways to do services in Sentry.

[codecov]

Codecov Report

Merging #51870 (05bcf2e) into master (d8ca28d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #51870   +/-   ##
=======================================
  Coverage    81.32    81.32           
=======================================
  Files        4901     4901           
  Lines      205867   205870    +3     
  Branches    11048    11048           
=======================================
+ Hits       167414   167419    +5     
+ Misses      38208    38206    -2     
  Partials      245      245           

Impacted Files	Coverage Δ
src/sentry/eventstore/processing/__init__.py	100.00% <100.00%> (ø)
src/sentry/eventstore/processing/base.py	93.93% <100.00%> (+0.18%)	⬆️
src/sentry/eventstore/processing/default.py	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[asottile-sentry]

[asottile-sentry]

appears to be breaking processing:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/src/sentry/src/sentry/__main__.py", line 3, in <module>
    main()
  File "/usr/src/sentry/src/sentry/runner/__init__.py", line 193, in main
    func(**kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/src/sentry/src/sentry/runner/decorators.py", line 69, in inner
    return ctx.invoke(f, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/src/sentry/src/sentry/runner/decorators.py", line 29, in inner
    return ctx.invoke(f, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/src/sentry/src/sentry/runner/commands/run.py", line 726, in basic_consumer
    run_processor_with_signals(processor)
  File "/usr/src/sentry/src/sentry/utils/kafka.py", line 13, in run_processor_with_signals
    processor.run()
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/processor.py", line 288, in run
    self._run_once()
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/processor.py", line 381, in _run_once
    self.__processing_strategy.submit(message)
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/strategies/guard.py", line 82, in submit
    self.__inner_strategy.submit(message)
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/strategies/run_task.py", line 52, in submit
    self.__next_step.submit(Message(value))
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/strategies/guard.py", line 34, in submit
    self.__next_step.submit(message)
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/strategies/guard.py", line 82, in submit
    self.__inner_strategy.submit(message)
  File "/usr/local/lib/python3.8/site-packages/arroyo/processing/strategies/run_task.py", line 50, in submit
    result = self.__function(cast(Message[TStrategyPayload], message))
  File "/usr/src/sentry/src/sentry/ingest/consumer_v2/ingest.py", line 54, in process_ingest_message
    process_event(message, project)
  File "/usr/src/sentry/src/sentry/ingest/ingest_consumer.py", line 40, in inner
    return f(*args, **kwargs)
  File "/usr/src/sentry/src/sentry/utils/metrics.py", line 199, in inner
    return f(*args, **kwargs)
  File "/usr/src/sentry/src/sentry/ingest/ingest_consumer.py", line 127, in process_event
    cache_key = event_processing_store.store(data)
  File "/usr/src/sentry/src/sentry/utils/services.py", line 103, in __getattr__
    self._setup()
  File "/usr/src/sentry/src/sentry/utils/services.py", line 119, in _setup
    assert issubclass(backend, Service)
TypeError: issubclass() arg 1 must be a class

[getsentry-bot]

PR reverted: 81dcc62