Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Make eventstore.processing use LazyServiceWrapper #51870

Merged
merged 1 commit into from
Jun 29, 2023
Merged

ref: Make eventstore.processing use LazyServiceWrapper #51870

merged 1 commit into from
Jun 29, 2023

Commits on Jun 29, 2023

  1. ref: Make eventstore.processing use LazyServiceWrapper 

    LazyServiceWrapper is a horrible old beast but it has a few sanity
checks that a simple `import_string` lacks. For starters, whether the
imported string even implements the relevant service baseclass.

Also LazyServiceWrapper supports typing now, while import_string would
require one additional type hint. That's easy to add but I don't
particularly care for having N ways to do services in Sentry.
    @untitaker
    untitaker committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    05bcf2e View commit details
    Browse the repository at this point in the history