feat(crons): Add helpful subtitle to crons issue platform + update evidence #51877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51877 +/- ##
==========================================
+ Coverage 81.32% 81.34% +0.01%
==========================================
Files 4901 4899 -2
Lines 205915 205790 -125
Branches 11048 11048
==========================================
- Hits 167465 167400 -65
+ Misses 38205 38145 -60
Partials 245 245
|
rjo100
changed the title
wedamija
reviewed
Jul 6, 2023
| def mark_failed(self, last_checkin=None, reason=MonitorFailure.UNKNOWN): | ||
| def get_last_successful_checkin(self): | ||
| return ( | ||
| MonitorCheckIn.objects.filter(monitor_environment=self, status=CheckInStatus.OK) |
There was a problem hiding this comment.
Do we need an index on monitor_env, status, date_added?
There was a problem hiding this comment.
Couldn't hurt...as long as the DB doesn't go crazy on us again. Would like to add that I guess and then will want to index on trace_id as well. Would it make sense to bundle together or separately?
There was a problem hiding this comment.
Might make sense to split the trace_id one out since we're not querying on it here? You could still bundle them together in the same ops ticket though.
There was a problem hiding this comment.
this indexing is complete
wedamija
approved these changes
Jul 12, 2023
|
PR reverted: 4d405d4 |
rjo100
added a commit
that referenced
this pull request
Jul 13, 2023
…idence (#51877) Adds helpful human-readable subtitle to issue platform crons issues + updates `last check-in` evidence to `last successful check-in`
michellewzhang
pushed a commit
that referenced
this pull request
Jul 13, 2023
…idence (#51877) Adds helpful human-readable subtitle to issue platform crons issues + updates `last check-in` evidence to `last successful check-in`
mifu67
pushed a commit
that referenced
this pull request
Jul 13, 2023
…idence (#51877) Adds helpful human-readable subtitle to issue platform crons issues + updates `last check-in` evidence to `last successful check-in`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds helpful human-readable subtitle to issue platform crons issues + updates
last check-inevidence tolast successful check-in