migration(crons): Add dangerous migration to add index for monitor en… #52562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vironment on check-ins
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Create index sentry_moni_monitor_1fb26c_idx on field(s) monitor_environment, date_added, status of model monitorcheckin
--
CREATE INDEX CONCURRENTLY "sentry_moni_monitor_1fb26c_idx" ON "sentry_monitorcheckin" ("monitor_environment_id", "date_added", "status"); |
markstory
approved these changes
Jul 10, 2023
wedamija
approved these changes
Jul 10, 2023
rjo100
commented
Jul 10, 2023
| # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to | ||
| # have ops run this and not block the deploy. Note that while adding an index is a schema | ||
| # change, it's completely safe to run the operation after the code has deployed. | ||
| is_dangerous = True |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vironment on check-ins
Work in preparation for #51877. Will cut a ticket to run the dangerous migration with OPS