Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration(crons): Add dangerous migration to add index for monitor en… #52562

Merged
merged 2 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
will then be regenerated, and you should be able to merge without conflicts.

nodestore: 0002_nodestore_no_dictfield
sentry: 0507_delete_pending_deletion_rules
sentry: 0508_index_checkin_monitorenvironment
social_auth: 0001_initial
33 changes: 33 additions & 0 deletions src/sentry/migrations/0508_index_checkin_monitorenvironment.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Generated by Django 2.2.28 on 2023-07-10 19:43

from django.db import migrations, models

from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production. For
# the most part, this should only be used for operations where it's safe to run the migration
# after your code has deployed. So this should not be used for most operations that alter the
# schema of a table.
# Here are some things that make sense to mark as dangerous:
# - Large data migrations. Typically we want these to be run manually by ops so that they can
# be monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# have ops run this and not block the deploy. Note that while adding an index is a schema
# change, it's completely safe to run the operation after the code has deployed.
is_dangerous = True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safety check


dependencies = [
("sentry", "0507_delete_pending_deletion_rules"),
]

operations = [
migrations.AddIndex(
model_name="monitorcheckin",
index=models.Index(
fields=["monitor_environment", "date_added", "status"],
name="sentry_moni_monitor_1fb26c_idx",
),
),
]
1 change: 1 addition & 0 deletions src/sentry/monitors/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ class Meta:
db_table = "sentry_monitorcheckin"
indexes = [
models.Index(fields=["monitor", "date_added", "status"]),
models.Index(fields=["monitor_environment", "date_added", "status"]),
models.Index(fields=["timeout_at", "status"]),
]

Expand Down