Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: upgrade django to 3.2 #52269

Merged
merged 4 commits into from
Jul 12, 2023
Merged

ref: upgrade django to 3.2 #52269

merged 4 commits into from
Jul 12, 2023

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jul 5, 2023 •
edited
Loading

rollout plan:

  • increase canary bake time to 60 (?) minutes
  • merge \o/

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 5, 2023
@asottile-sentry asottile-sentry force-pushed the asottile-django-3-2 branch 2 times, most recently from fa47e7d to 7d22018 Compare July 7, 2023 13:18
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #52269 (e54b457) into master (5deb12e) will increase coverage by 26.73%.
The diff coverage is 100.00%.

❗ Current head e54b457 differs from pull request most recent head 8afa9e6. Consider uploading reports for the commit 8afa9e6 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #52269       +/-   ##
===========================================
+ Coverage   52.63%   79.36%   +26.73%     
===========================================
  Files        4876     4921       +45     
  Lines      204807   206429     +1622     
  Branches    35007    35291      +284     
===========================================
+ Hits       107793   163834    +56041     
+ Misses      94867    37573    -57294     
- Partials     2147     5022     +2875
Impacted Files Coverage Δ
src/sentry/new_migrations/monkey/__init__.py 77.77% <100.00%> (ø)
src/sentry/rules/history/backends/postgres.py 100.00% <100.00%> (+41.46%) ⬆️
...entry/silo/patches/silo_aware_transaction_patch.py 83.33% <100.00%> (-0.99%) ⬇️
src/sentry/utils/email/signer.py 89.47% <100.00%> (+39.47%) ⬆️

... and 1743 files with indirect coverage changes

@asottile-sentry asottile-sentry marked this pull request as ready for review July 11, 2023 21:25
@asottile-sentry asottile-sentry requested review from a team as code owners July 11, 2023 21:25
@asottile-sentry asottile-sentry requested a review from a team July 11, 2023 21:25
@evanpurkhiser
Copy link
Member

🥵

@asottile-sentry asottile-sentry merged commit 1e47eee into master Jul 12, 2023
@asottile-sentry asottile-sentry deleted the asottile-django-3-2 branch July 12, 2023 12:38
@asottile-sentry
Copy link
Member Author

ran out of time to try this for today -- will try again tomorrow

@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jul 12, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 755a01a

getsentry-bot added a commit that referenced this pull request Jul 12, 2023
@getsentry-bot @asottile-sentry
Revert "ref: upgrade django to 3.2 (#52269)"
755a01a 
This reverts commit 1e47eee.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
@asottile-sentry asottile-sentry mentioned this pull request Jul 12, 2023
Merged
asottile-sentry added a commit that referenced this pull request Jul 12, 2023
@asottile-sentry
Revert "Revert "ref: upgrade django to 3.2 (#52269)""
b9dad36 
This reverts commit 755a01a.
asottile-sentry added a commit that referenced this pull request Jul 13, 2023
@asottile-sentry
ref: upgrade django to 3.2 (#52713)
25c3897 
same as #52269 -- but I ran out of time to deploy it
michellewzhang pushed a commit that referenced this pull request Jul 13, 2023
@asottile-sentry
ref: upgrade django to 3.2 (#52713)
29817e3 
same as #52269 -- but I ran out of time to deploy it
mifu67 pushed a commit that referenced this pull request Jul 13, 2023
@asottile-sentry @mifu67
ref: upgrade django to 3.2 (#52713)
0478b18 
same as #52269 -- but I ran out of time to deploy it
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattgauntseo-sentry mattgauntseo-sentry mattgauntseo-sentry approved these changes

@wedamija wedamija wedamija approved these changes

@corps corps corps approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asottile-sentry @evanpurkhiser @getsentry-bot @corps @wedamija @mattgauntseo-sentry