fix(django_admin): Disable django_admin on prod #52329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52329 +/- ##
==========================================
- Coverage 79.32% 79.31% -0.01%
==========================================
Files 4907 4907
Lines 205595 205595
Branches 35148 35148
==========================================
- Hits 163081 163074 -7
- Misses 37534 37540 +6
- Partials 4980 4981 +1
|
BYK
suggested changes
Jul 6, 2023
|
/gcbrun |
Seems to work, just tested this locally. Thanks @klboke |
hubertdeng123
approved these changes
Jul 7, 2023
|
Let's get a review from the backend team as well. |
markstory
approved these changes
Jul 10, 2023
dashed
approved these changes
Jul 10, 2023
chadwhitacre
added
the
Trigger: getsentry tests
markstory
added a commit
that referenced
this pull request
Jul 11, 2023
We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329) Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list.
markstory
added a commit
that referenced
this pull request
Jul 12, 2023
We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329) Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable django_admin on prod ，fix #23742 , getsentry/self-hosted#1039
cc @BYK
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.