feat(hybridcloud) Add shared secret and signatures to RPC requests #52842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing RPC requests we should have authentication on requests. I've gone with a simple request signature HMAC verfication as it felt like the simplest solution that was tamper & forgery resistant. Previously we had planned on using mTLS as authentication between regions. Setting up a cerfiticate authority and managing certificates is more scope than we presently have capacity for. I'm anticipating us needing to do key rotation, or signature upgrades in the future and have accounted for both in the current design. Refs HC-730
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52842 +/- ##
==========================================
- Coverage 79.48% 79.48% -0.01%
==========================================
Files 4935 4935
Lines 207668 207762 +94
Branches 35453 35470 +17
==========================================
+ Hits 165069 165133 +64
- Misses 37570 37601 +31
+ Partials 5029 5028 -1
|
Using requests lets us use responses for mocks which is more consistent with other network stubs that we have in the application.
corps
approved these changes
Jul 18, 2023
|
PR reverted: f9bc819 |
markstory
added a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing RPC requests we should have authentication on requests. I've gone with a simple request signature HMAC verfication as it felt like the simplest solution that was tamper & forgery resistant. Previously we had planned on using mTLS as authentication between regions. Setting up a cerfiticate authority and managing certificates is more scope than we presently have capacity for.
I'm anticipating us needing to do key rotation, or signature upgrades in the future and have accounted for both in the current design.
Refs HC-730