Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hybridcloud) Add shared secret and signatures to RPC requests #52842

Merged
merged 8 commits into from
Jul 18, 2023

Commits on Jul 13, 2023

  1. feat(hybridcloud) Add shared secret and signatures to RPC requests

    When doing RPC requests we should have authentication on requests. I've
    gone with a simple request signature HMAC verfication as it felt like
    the simplest solution that was tamper & forgery resistant. Previously
    we had planned on using mTLS as authentication between regions. Setting
    up a cerfiticate authority and managing certificates is more scope than
    we presently have capacity for.
    
    I'm anticipating us needing to do key rotation, or signature upgrades in
    the future and have accounted for both in the current design.
    
    Refs HC-730
    markstory committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1789b43 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Add default value and docs.

    markstory committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d91d82e View commit details
    Browse the repository at this point in the history
  2. Switch to using requests and update tests.

    Using requests lets us use responses for mocks which is more consistent
    with other network stubs that we have in the application.
    markstory committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cdc852c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b30fef View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. typing for the type gods

    markstory committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    7f84965 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Configuration menu
    Copy the full SHA
    c574d98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    517db50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97b14a6 View commit details
    Browse the repository at this point in the history