feat(alerts): on demand metric time series support #52867
Conversation
github-actions
bot
added
Scope: Frontend
| @@ -101,7 +101,7 @@ def _resolve_on_demand_spec( | |||
| return None | |||
|
|
|||
| field = selected_cols[0] if selected_cols else None | |||
| if not self.is_alerts_query or not field: | |||
There was a problem hiding this comment.
we need this to execute also for TimeseriesQueryBuilder now
obostjancic
force-pushed
the
ogi/feat/on-demand-alerts-chart
branch
from
b78d567
to
c4ecde8
Compare
obostjancic
removed
the
Scope: Frontend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52867 +/- ##
==========================================
- Coverage 79.47% 79.46% -0.01%
==========================================
Files 4936 4936
Lines 207488 207492 +4
Branches 35423 35444 +21
==========================================
- Hits 164892 164875 -17
- Misses 37565 37582 +17
- Partials 5031 5035 +4
|
obostjancic
changed the title
| @@ -136,6 +136,7 @@ | |||
| "os.name", | |||
| "geo.country_code", | |||
| "event.type", | |||
| "project", | |||
There was a problem hiding this comment.
Could we add a comment before event.type that these are query filters we support as input, but they will not be converted into a rule condition?
I think you still need to account for project somehow in conversion, because it cannot be a valid rule condition. How does this turn up and how are you planning to handle this? Ideally, please add a unit test for this.
There was a problem hiding this comment.
Added a comment
Removed the project field, it was there just for one of the tests
|
PR reverted: 4856ab5 |
This reverts commit f95d541. Co-authored-by: obostjancic <86684834+obostjancic@users.noreply.github.com>
Related to Support chart queries for on-demand metrics#52508
Enables time series querying of on demand metrics