-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): on demand metric time series support #52867
Changes from 9 commits
9684af3
68586dd
c4ecde8
e1d4ec4
a6229ac
6da4e6e
eb939c5
b8fc1cd
ef71fd4
1eb6e1d
854d407
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,6 +136,7 @@ | |
"os.name", | ||
"geo.country_code", | ||
"event.type", | ||
"project", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we add a comment before I think you still need to account for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a comment |
||
] | ||
|
||
# Operators used in ``ComparingRuleCondition``. | ||
|
@@ -306,7 +307,7 @@ def __init__(self, field: str, query: str): | |
|
||
# On-demand metrics are implicitly transaction metrics. Remove the | ||
# filter from the query since it can't be translated to a RuleCondition. | ||
self._query = re.sub(r"event\.type:transaction\s*", "", query) | ||
self._query = re.sub(r"event\.type:transaction\s*", "", query).strip() | ||
self._init_aggregate(field) | ||
|
||
def _init_aggregate(self, aggregate: str) -> None: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this to execute also for
TimeseriesQueryBuilder
now