test(hybrid-cloud): Stabilizes sentry app install tests #53004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
GabeVillalobos
commented
Jul 17, 2023
| @@ -16,7 +16,7 @@ | |||
| from sentry.testutils.outbox import outbox_runner | |||
|
|
|||
|
|
|||
| class TestSentryAppIntallationDeletionTask(TestCase): | |||
There was a problem hiding this comment.
Realized this was misspelled as I was fixing the test 😅
GabeVillalobos
added
the
Trigger: Silo db
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53004 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 4936 4936
Lines 207432 207432
Branches 35425 35425
=======================================
+ Hits 164833 164838 +5
+ Misses 37560 37559 -1
+ Partials 5039 5035 -4
|
markstory
approved these changes
Jul 17, 2023
GabeVillalobos
removed
the
Trigger: Silo db
This was referenced Jul 18, 2023
GabeVillalobos
added a commit
that referenced
this pull request
Jul 19, 2023
…using unguarded_write decorators (#53160) With the inclusion of our recent changes to transaction validations in PR #52943 and the inclusion of 'using' in all of our transactions/helpers thanks to PRs #53027 and #53004, we should be able to safely remove the ability to specify a transaction without a using keyword arg. Because this is now mandatory, it should also be safe to remove autorouting, which ended up being incorrect in many testing contexts anyway. This is a resubmission of PR #53080 which was reverted due to broken load-mocks and a single broken getsentry migration test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes?