feat(perf-detector-threshold-configuration) Added datamigration for c… #53109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onverting worldmap widgets to table widgets.
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53109 +/- ##
==========================================
- Coverage 79.54% 76.09% -3.46%
==========================================
Files 4941 4939 -2
Lines 208722 208670 -52
Branches 35551 35551
==========================================
- Hits 166028 158784 -7244
- Misses 37632 44770 +7138
- Partials 5062 5116 +54 |
wedamija
reviewed
Jul 21, 2023
| if "geo.region" not in widgetQuery.columns: | ||
| widgetQuery.columns.insert(0, "geo.region") | ||
| if "geo.country_code" not in widgetQuery.columns: | ||
| widgetQuery.columns.insert(0, "geo.country_code") |
There was a problem hiding this comment.
Why do we insert to the start of the list here? Is the order important?
There was a problem hiding this comment.
Yeah we care about the order here. We want country_code and region to be the first two columns/fields. @wedamija
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
wedamija
approved these changes
Jul 24, 2023
wmak
approved these changes
Jul 24, 2023
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
|
PR reverted: 6543790 |
Abdkhan14
added a commit
that referenced
this pull request
Jul 25, 2023
…53475) - Migration already approved here: [PR](#53109) but it had a runtime error. - Added null checks for columns and fields in DashboardWidgetQuery. - Should fix run time error from previous migration attempt: <img width="488" alt="Screenshot 2023-07-24 at 6 17 48 PM" src="https://github.com/getsentry/sentry/assets/60121741/49fe3214-77c3-4bdb-b02f-355eb567f1d3"> - Link to failure: https://deploy.getsentry.net/go/tab/build/detail/deploy-getsentry-backend-us/63/migrations/1/migrations - Tested it out locally with NULL columns. Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
chloeho7
pushed a commit
that referenced
this pull request
Jul 25, 2023
…53475) - Migration already approved here: [PR](#53109) but it had a runtime error. - Added null checks for columns and fields in DashboardWidgetQuery. - Should fix run time error from previous migration attempt: <img width="488" alt="Screenshot 2023-07-24 at 6 17 48 PM" src="https://github.com/getsentry/sentry/assets/60121741/49fe3214-77c3-4bdb-b02f-355eb567f1d3"> - Link to failure: https://deploy.getsentry.net/go/tab/build/detail/deploy-getsentry-backend-us/63/migrations/1/migrations - Tested it out locally with NULL columns. Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Abdkhan14
added a commit
that referenced
this pull request
Jul 25, 2023
…ver chart. (#53185) For issue: #51315 Steps outlined: [here](https://www.notion.so/sentry/Removing-World-Map-display-from-Discover-and-Dashboards-e49eb198fe294ad0a1b4c47b9c3619c0?pvs=4#43e2c318d1eb4f93987718b82307f56f). - Won't be merging until, data-migration [PR](#53109) for converting world map widgets to table widgets is deployed. - Removes the World map display mode from discover chart footer: <img width="1104" alt="Screenshot 2023-07-19 at 3 59 54 PM" src="https://github.com/getsentry/sentry/assets/60121741/80ca9e8e-aeb4-45ab-92a4-bda951b426f5"> - Should not effect the loading of existing discover saved queries, homepages and previews with world map display mode: - - Falls back to AreaChart instead of WorldMapChart: [code](https://github.com/getsentry/sentry/blob/4bd6934f1b3f947043ef93b1dd35a11b1e9927cf/static/app/components/charts/eventsChart.tsx#L140-L163) - - Falls back to Total Period display mode instead: [code](https://github.com/getsentry/sentry/blob/9b816eae27f4a29eedad50e5ed8af86188badec1/static/app/utils/discover/eventView.tsx#L1403-L1426) - Removed tests and blocks of code using: `DisplayMode.WORLDMAP`. - Added unused components like `WorldMapChart` and `EventsGeoRequest` to clean up list for removal. --------- Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #51315
Steps outlined: here.
'has:geo_country_code'condition is addded to each Widget Query.'geo.country_code'and'geo.region'columns to each Widget Query.'geo.country_code'and'geo.region'fields to each Widget Query.