ref(on-demand): Improve query builder integration #54363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54363 +/- ##
==========================================
+ Coverage 79.64% 79.66% +0.01%
==========================================
Files 4986 4989 +3
Lines 211350 211579 +229
Branches 36032 36065 +33
==========================================
+ Hits 168332 168548 +216
- Misses 37833 37839 +6
- Partials 5185 5192 +7
|
obostjancic
approved these changes
Aug 9, 2023
|
PR reverted: 56fd332 |
getsentry-bot
added a commit
that referenced
this pull request
Aug 9, 2023
This reverts commit d7e2588. Co-authored-by: iambriccardo <15819674+iambriccardo@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the integration of the on demand metrics into the query builder by introducing a new memoized property called
_on_demand_metric_specwhich will fetch, irrespectively of the constructor's lifecycle, all the required data for a successful execution.In addition, this PR adds some better tests for the query generation, since it's a very delicate piece of code.