Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(on-demand): Improve query builder integration #54441

Merged
merged 8 commits into from
Aug 9, 2023
Merged

ref(on-demand): Improve query builder integration #54441

merged 8 commits into from
Aug 9, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Aug 9, 2023 •
edited
Loading

This PR fixes an issue introduced in #54363.

@iambriccardo iambriccardo requested a review from a team as a code owner August 9, 2023 09:49
@iambriccardo iambriccardo requested a review from a team August 9, 2023 09:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 9, 2023
obostjancic
obostjancic approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@obostjancic obostjancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the comment 😅

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #54441 (ffb7121) into master (cac31d6) will increase coverage by 0.01%.
Report is 55 commits behind head on master.
The diff coverage is 88.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #54441      +/-   ##
==========================================
+ Coverage   79.64%   79.66%   +0.01%     
==========================================
  Files        4986     4989       +3     
  Lines      211350   211583     +233     
  Branches    36032    36066      +34     
==========================================
+ Hits       168332   168557     +225     
- Misses      37833    37837       +4     
- Partials     5185     5189       +4
Files Changed Coverage Δ
src/sentry/search/events/builder/metrics.py 81.99% <88.63%> (-0.49%) ⬇️
src/sentry/search/events/builder/discover.py 91.86% <100.00%> (+<0.01%) ⬆️

... and 126 files with indirect coverage changes

@iambriccardo iambriccardo merged commit 05355c4 into master Aug 9, 2023
55 of 56 checks passed
@iambriccardo iambriccardo deleted the riccardo/ref/query-builder-on-demand branch August 9, 2023 11:02
@iambriccardo iambriccardo added the Trigger: Revert add to a merged PR to revert it (skips CI) label Aug 9, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: f3e536d

getsentry-bot added a commit that referenced this pull request Aug 9, 2023
@getsentry-bot @iambriccardo
Revert "ref(on-demand): Improve query builder integration (#54441)"
f3e536d 
This reverts commit 05355c4.

Co-authored-by: iambriccardo <15819674+iambriccardo@users.noreply.github.com>
@iambriccardo iambriccardo restored the riccardo/ref/query-builder-on-demand branch August 9, 2023 12:01
@iambriccardo iambriccardo mentioned this pull request Aug 9, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obostjancic obostjancic obostjancic approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iambriccardo @getsentry-bot @obostjancic