Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add thresholds to monitor config #54516

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Aug 10, 2023

Adds failure_issue_threshold for value to create issues and recovery_threshold for value to resolve issues.

Closes #54514

@rjo100 rjo100 requested a review from a team as a code owner August 10, 2023 00:21
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #54516 (4bf6e38) into master (0dead08) will increase coverage by 0.07%.
Report is 67 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54516      +/-   ##
==========================================
+ Coverage   79.67%   79.74%   +0.07%     
==========================================
  Files        4989     4991       +2     
  Lines      211666   212067     +401     
  Branches    36073    36146      +73     
==========================================
+ Hits       168643   169115     +472     
+ Misses      37834    37747      -87     
- Partials     5189     5205      +16     
Files Changed Coverage Δ
src/sentry/monitors/models.py 92.35% <ø> (ø)
src/sentry/monitors/validators.py 91.42% <100.00%> (+0.12%) ⬆️

... and 76 files with indirect coverage changes

@rjo100 rjo100 merged commit d21b29c into master Aug 10, 2023
56 of 57 checks passed
@rjo100 rjo100 deleted the rjo100/initial-stateful-monitors branch August 10, 2023 20:48
@rjo100 rjo100 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Aug 10, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: c7739e0

getsentry-bot added a commit that referenced this pull request Aug 10, 2023
This reverts commit d21b29c.

Co-authored-by: rjo100 <7078270+rjo100@users.noreply.github.com>
rjo100 added a commit that referenced this pull request Aug 10, 2023
Adds `failure_issue_threshold` for value to create issues and
`recovery_threshold` for value to resolve issues.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add thresholds to monitor config
3 participants