feat(commit-context): Do not create if older than 1 year #54624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54624 +/- ##
==========================================
+ Coverage 79.74% 79.78% +0.03%
==========================================
Files 4995 5000 +5
Lines 212230 212382 +152
Branches 36179 36191 +12
==========================================
+ Hits 169247 169440 +193
+ Misses 37775 37730 -45
- Partials 5208 5212 +4
|
snigdhas
approved these changes
Aug 14, 2023
wedamija
reviewed
Aug 14, 2023
| # Only return suspect commits that are less than a year old | ||
| if commit_context and datetime.strptime( | ||
| commit_context["committedDate"], "%Y-%m-%dT%H:%M:%SZ" | ||
| ).replace(tzinfo=timezone.utc) > datetime.now(tz=timezone.utc) - timedelta(days=365): |
There was a problem hiding this comment.
This should probably be a constant or a setting somewhere
NisanthanNanthakumar
deleted the
do-not-create-suspect-commit-if-its-older-than-1-year
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
asottile-sentry
added
the
Trigger: Revert
|
PR reverted: d5a3714 |
getsentry-bot
added a commit
that referenced
this pull request
Aug 15, 2023
)" This reverts commit 14935b6. Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
NisanthanNanthakumar
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Objective Update on the reverted PR: #54624 The original PR had errors from GitLab date strings not being parsed correctly bc they are formatted differently from GitHub. So this PR returns the datetime object for internal usage and will make date comparisons easier without needing to know which integration it came from.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
Do not create a suspect commit if the resulting commit is over 1 year old.