feat(team-workflow): Add subscription for team in GroupSubscription
#55825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #55825 +/- ##
==========================================
- Coverage 79.98% 78.29% -1.70%
==========================================
Files 5063 5064 +1
Lines 217835 217881 +46
Branches 36878 36885 +7
==========================================
- Hits 174241 170584 -3657
- Misses 38247 41892 +3645
- Partials 5347 5405 +58 |
This comment was marked as outdated.
This comment was marked as outdated.
roggenkemper
reviewed
Sep 7, 2023
roggenkemper
reviewed
Sep 8, 2023
| @@ -88,6 +97,23 @@ def test_actor_team(self): | |||
| # should not error | |||
| GroupSubscription.objects.subscribe_actor(group=group, actor=team) | |||
|
|
|||
| @with_feature("organizations:team-workflow-notifications") | |||
| def test_subscribe_team(self): | |||
scefali
reviewed
Sep 12, 2023
scefali
approved these changes
Sep 12, 2023
isabellaenriquez
deleted the
isabellaenriquez/subscribe-team-not-users
branch
isabellaenriquez
added
the
Trigger: Revert
|
PR reverted: 6efc462 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
subscribe_actorto no longer read all the team's users and instead subscribe the Team itself if the team-workflow-notifications feature flag is enabled. Also updatessubscribeso that it can accept a Team as a subscriber, not just Users or RpcUsers.Part 1 of #55556
❗ BLOCKED BY #55879