feat(save_event): Always use cache for stacktrace processing #56413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We enabled it for EA customers last week without any issues. It reduces the stacktrace normalization by 40%.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Sep 18, 2023
| @@ -2411,14 +2411,10 @@ def _calculate_event_grouping( | |||
| Main entrypoint for modifying/enhancing and grouping an event, writes | |||
| hashes back into event payload. | |||
| """ | |||
| load_stacktrace_from_cache = bool(event.org_can_load_stacktrace_from_cache) | |||
There was a problem hiding this comment.
We remove the method in eventstore/models.
| @@ -491,10 +487,6 @@ def get_span_groupings( | |||
| def organization(self) -> Organization: | |||
| return self.project.organization | |||
|
|
|||
| @property | |||
| def org_can_load_stacktrace_from_cache(self) -> bool: | |||
| return features.has("organizations:stacktrace-processing-caching", self.organization) | |||
There was a problem hiding this comment.
This feature still shows up in src/sentry/features/__init__.py since it's still in use in getsentry. We can remove it once we remove it's use from getsentry.
| ) | ||
| if changed_frames_values and load_from_cache: | ||
| if changed_frames_values: |
There was a problem hiding this comment.
This is what enables it for everyone.
Codecov Report
@@ Coverage Diff @@
## master #56413 +/- ##
========================================
Coverage 78.64% 78.64%
========================================
Files 5075 5076 +1
Lines 218067 218205 +138
Branches 36905 36934 +29
========================================
+ Hits 171490 171615 +125
- Misses 41044 41046 +2
- Partials 5533 5544 +11
|
scttcper
approved these changes
Sep 19, 2023
|
PR reverted: bb386fa |
|
Revert due to large backlogs seen in ingest-attachments that align with this change. |
armenzg
added a commit
that referenced
this pull request
Sep 20, 2023
We enabled it for EA customers last week without any issues. It reduces the stacktrace normalization by 40%. It's most noticeable with Native events. A repeat of #56413 which got reverted by mistake.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enabled it for EA customers last week without any issues. It reduces the stacktrace normalization by 40%. It's most noticeable with Native events.