Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Throw error on non-json api responses #57634

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat(ui): Throw error on non-json api responses #57634

merged 3 commits into from
Oct 10, 2023

Commits on Oct 5, 2023

  1. feat(ui): Throw error on non-json api responses 

    We get 200 response codes sometimes from local network firewalls that contain html. We should not pass the text response as this throws confusing errors further downstream.
    @scttcper
    scttcper committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d8ef98b View commit details
    Browse the repository at this point in the history

  2. rename headers

    @scttcper
    scttcper committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1331894 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. allow empty responses

    @scttcper
    scttcper committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c762cae View commit details
    Browse the repository at this point in the history