feat(ui): Throw error on non-json api responses #57634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get 200 response codes sometimes from local network firewalls that contain html. We should not pass the text response as this throws confusing errors further downstream.
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Oct 5, 2023
ryan953
approved these changes
Oct 5, 2023
lobsterkatie
reviewed
Oct 5, 2023
|
PR reverted: 423be54 |
getsentry-bot
added a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit 6c5aa19. Co-authored-by: malwilley <10888943+malwilley@users.noreply.github.com>
scttcper
added a commit
that referenced
this pull request
Oct 13, 2023
…)"" This reverts commit 423be54.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get 200 response codes sometimes from local network firewalls or adblockers that contain html. We should not pass the text response as this throws confusing errors further downstream.
fixes JAVASCRIPT-2MZ6