Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Throw error on non-json api responses #57634

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat(ui): Throw error on non-json api responses #57634

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8ef98b
feat(ui): Throw error on non-json api responses
scttcper Oct 5, 2023
1331894
rename headers
scttcper Oct 5, 2023
c762cae
allow empty responses
scttcper Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions static/app/api.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ export class Client {

const responseContentType = response.headers.get('content-type');
const isResponseJSON = responseContentType?.includes('json');
const wasExpectingJson = headers.get('Content-Type') === 'application/json';
lobsterkatie marked this conversation as resolved.
Show resolved Hide resolved

const isStatus3XX = status >= 300 && status < 400;
if (status !== 204 && !isStatus3XX) {
Expand All @@ -550,6 +551,11 @@ export class Client {
// this should be an error.
ok = false;
errorReason = 'JSON parse error';
} else if (wasExpectingJson && error instanceof SyntaxError) {
// Was expecting json but was returned something else. Possibly HTML.
// Ideally this would not be a 200, but we should reject the promise
ok = false;
errorReason = 'JSON parse error. Possibly returned HTML';
}
}
}
Expand Down
Loading