feat(stats): Display subseries in tooltip #73774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 3.08kB ⬆️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73774 +/- ##
==========================================
- Coverage 78.12% 78.10% -0.02%
==========================================
Files 6661 6665 +4
Lines 298042 297646 -396
Branches 51278 51200 -78
==========================================
- Hits 232834 232480 -354
+ Misses 58919 58882 -37
+ Partials 6289 6284 -5
|
priscilawebdev
force-pushed
the
priscila/ref/stats/display-subseries-tooltip
branch
from
9e149d5
to
eb53f83
Compare
scttcper
approved these changes
Jul 3, 2024
scttcper
reviewed
Jul 3, 2024
| @@ -115,7 +117,7 @@ class UsageStatsOrganization< | |||
| return { | |||
| ...queryDatetime, | |||
| interval: getSeriesApiInterval(dataDatetime), | |||
| groupBy: ['category', 'outcome'], | |||
| groupBy: ['category', 'outcome', 'reason'], | |||
There was a problem hiding this comment.
does this need to be behind a feature flag?
There was a problem hiding this comment.
If I recall correctly, no, but let me check again to confirm.
vgrozdanic
approved these changes
Jul 4, 2024
matejminar
approved these changes
Jul 4, 2024
priscilawebdev
added a commit
that referenced
this pull request
Jul 5, 2024
This reverts commit 479ea5a.
priscilawebdev
added
the
Trigger: Revert
|
PR reverted: 5e2457d |
getsentry-bot
added a commit
that referenced
this pull request
Jul 5, 2024
This reverts commit 479ea5a. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
On the stats page, we aim to provide more detailed information about the statistics. Currently, we display the outcomes: Accepted, Filtered, and Dropped, but we should also include specifics about what was filtered and what was dropped.
Before:
After:
Note
Discarded will be included in a follow-up
Part of #59320