chore(hybrid-cloud): Upgrade Pydantic to version 2.7 #74770
Conversation
…assword_hash model Also fixes test type mismatches.
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
.github/workflows/backend.yml
Outdated
| @@ -10,7 +10,7 @@ on: | |||
| # https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value | |||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |||
| cancel-in-progress: true | |||
| cancel-in-progress: false | |||
There was a problem hiding this comment.
This is only set for obtaining test results. This will be removed prior to merging.
Bundle ReportChanges will increase total bundle size by 11.02kB ⬆️
|
GabeVillalobos
force-pushed
the
gv/pydantic-v2-7-upgrade
branch
from
07e0ca9
to
b0ed17a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74770 +/- ##
===========================================
+ Coverage 57.35% 78.18% +20.83%
===========================================
Files 6539 6743 +204
Lines 288766 300997 +12231
Branches 49672 51776 +2104
===========================================
+ Hits 165609 235335 +69726
+ Misses 118600 59297 -59303
- Partials 4557 6365 +1808
|
…ting" This reverts commit 49756fc.
| @@ -45,7 +45,7 @@ python-rapidjson>=1.4 | |||
| psutil>=5.9.2 | |||
| psycopg2-binary>=2.9.9 | |||
| PyJWT>=2.4.0 | |||
| pydantic>=1.10.17,<2 | |||
| pydantic>=2.5.0 | |||
There was a problem hiding this comment.
| pydantic>=2.5.0 | |
| pydantic>=2.5.0,<3 |
Could we pin to the 2.x range so that we don't accidentally bump a major?
There was a problem hiding this comment.
there's no risk to uncapping here -- in fact it's encouraged
this file isn't installed from -- it's used to generate the pinned file
GabeVillalobos
added
the
Trigger: Revert
|
PR reverted: 2525223 |
This reverts commit 106b00a. Co-authored-by: GabeVillalobos <5643012+GabeVillalobos@users.noreply.github.com>
This reverts commit 106b00a. Co-authored-by: GabeVillalobos <5643012+GabeVillalobos@users.noreply.github.com>
Based on PR #74766, which should be merged first.
This PR upgrades pydantic and updates the model configs we use for RPC methods to conform with the new version.
This PR does not address deprecation warnings, which will be handled in a series of follow-up commits to both Sentry and GetSentry.