Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(metrics): Replace SmartSearch with SearchQueryBuilder component #75058

Merged
merged 1 commit into from
Jul 29, 2024
Merged

ref(metrics): Replace SmartSearch with SearchQueryBuilder component #75058

merged 1 commit into from
Jul 29, 2024

Conversation

priscilawebdev
Copy link
Member

Goal

Replace the component SmartSearchBar with SearchQueryBuilder based on the instructions.

The changes are behind the feature flag organizations:search-query-builder-metrics as defined in the file

@priscilawebdev priscilawebdev requested a review from a team as a code owner July 26, 2024 12:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will increase total bundle size by 691 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.4MB 691 bytes ⬆️

@malwilley malwilley mentioned this pull request Jul 26, 2024
Merged
malwilley
malwilley approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for implementing so quickly!

This PR will fix an issue where the onChange was firing constantly: #75082

obostjancic
obostjancic approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@obostjancic obostjancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out in the preview env. LGTM 🚀

@priscilawebdev priscilawebdev merged commit 083f1d5 into master Jul 29, 2024
42 of 43 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/metrics/replace-smart-search branch July 29, 2024 11:30
@shellmayr shellmayr added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jul 29, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: c3fda10

getsentry-bot added a commit that referenced this pull request Jul 29, 2024
@getsentry-bot @shellmayr
Revert "ref(metrics): Replace SmartSearch with SearchQueryBuilder com…
c3fda10 
…ponent (#75058)"

This reverts commit 083f1d5.

Co-authored-by: shellmayr <6788060+shellmayr@users.noreply.github.com>
@priscilawebdev priscilawebdev mentioned this pull request Jul 30, 2024
Merged
@malwilley malwilley mentioned this pull request Aug 7, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obostjancic obostjancic obostjancic approved these changes

@malwilley malwilley malwilley approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@priscilawebdev @getsentry-bot @malwilley @obostjancic @shellmayr