fix(query-builder): Modify callbacks to include more information and only fire when necessary #75082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only fire when necessary
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 127 bytes ⬆️
|
roggenkemper
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue uncovered with this PR: #75058
The onChange was firing far too frequently, because the
onChangepassed in was not memoized. We can prevent this by trackingpreviousQuery.Also added some extra info to the callback, like whether the query is valid and the parsed contents since that should be useful for some implementations.