Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumbs): Use subgrid to align log levels #76148

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

scttcper
Copy link
Member

attempts to fix this but i think it might drive the virtual scroll crazy https://www.notion.so/sentry/Breadcrumb-level-horizontal-alignment-f7e13defa53d40d7a0af8aa6c73ea085
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2024
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scttcper scttcper merged commit 9a99b0f into master Aug 14, 2024
41 checks passed
@scttcper scttcper deleted the scttcper/breadcrumb-subgrid branch August 14, 2024 19:24
@scttcper scttcper added the Trigger: Revert add to a merged PR to revert it (skips CI) label Aug 14, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: d08c805

getsentry-bot added a commit that referenced this pull request Aug 14, 2024
This reverts commit 9a99b0f.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants