Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breadcrumbs): Use subgrid to align log levels #76148

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix(breadcrumbs): Use subgrid to align log levels #76148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2727b01
fix(breadcrumbs): Use subgrid to align log levels
scttcper Aug 14, 2024
39da9bb
fiddle with margin
scttcper Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static/app/components/events/breadcrumbs/breadcrumbsTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ const Subtitle = styled('p')`

const Timestamp = styled('div')`
margin-right: ${space(1)};
text-align: right;
color: ${p => p.theme.subText};
font-size: ${p => p.theme.fontSizeSmall};
span {
Expand Down
17 changes: 9 additions & 8 deletions static/app/components/timeline/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,13 @@ export const Item = forwardRef(function _Item(
const Row = styled('div')<{showLastLine?: boolean}>`
position: relative;
color: ${p => p.theme.subText};
display: grid;
align-items: start;
grid-template: auto auto / 22px 1fr auto;
grid-column-gap: ${space(1)};
margin: ${space(1)} 0;
&:first-child {
margin-top: 0;
}
display: grid;
grid-template-columns: subgrid;
grid-column: 1/-1;
grid-row-gap: ${space(0.5)};

&:last-child {
margin-bottom: 0;
/* Show/hide connecting line from the last element of the timeline */
background: ${p => (p.showLastLine ? 'transparent' : p.theme.background)};
}
Expand Down Expand Up @@ -136,6 +133,10 @@ export const Data = styled('div')`

export const Container = styled('div')`
position: relative;
display: grid;
grid-template: auto auto / 22px 1fr auto;
grid-row-gap: ${space(1)};
grid-column-gap: ${space(1)};
/* vertical line connecting items */
&::before {
content: '';
Expand Down
Loading