-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(derived_code_mappings): Report errors with warning level #76212
Conversation
Using info level errors or exceptions avoids creating alerts and possibly showing up in releases, thus, not blocking deployments. All of these errors are harmless and I'm aiming to investigate them over time to determine if any of them contain a real bug.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run timetests.sentry.integrations.github.test_integration.GitHubIntegrationTest�test_get_trees_for_org_rate_limit_401 To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if this works? given the test failure. i think my idea was to use sentry APIs directly.
This reports the exception as warning level rather than error level. Deployments do not get paused if the error is warning or lower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are different execution paths depending on the method used. The logging integration does not allow for it.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
PR reverted: 47dd90f |
This reports the exceptions as warning-level errors rather than error-level. Deployments do not get paused if the error is [warning or lower](https://github.com/getsentry/getsentry/blob/b08907d9da3e8856c6cbedbd86d4a722c6f89dd9/gocd/templates/bash/backend/check-sentry-new-errors.sh#L12): ``` --additional-query="issue.type:error !level:info !level:warning" ``` Rendering of a warning-level exception: <img width="265" alt="image" src="https://github.com/user-attachments/assets/cd630c9b-9ac7-4894-aa33-736789c17c0b">
This reports the exceptions as warning-level errors rather than error-level. Deployments do not get paused if the error is [warning or lower](https://github.com/getsentry/getsentry/blob/b08907d9da3e8856c6cbedbd86d4a722c6f89dd9/gocd/templates/bash/backend/check-sentry-new-errors.sh#L12): ``` --additional-query="issue.type:error !level:info !level:warning" ``` Rendering of a warning-level exception: <img width="265" alt="image" src="https://github.com/user-attachments/assets/cd630c9b-9ac7-4894-aa33-736789c17c0b"> PS: This is a redo of #76212 but without passing a level, thus, making it an info-level message.
This reports the exceptions as warning-level errors rather than error-level.
Deployments do not get paused if the error is warning or lower:
Rendering of a warning-level exception: