chore(derived_code_mappings): Report known issues as non-errors #76616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reports the exceptions as warning-level errors rather than error-level. Deployments do not get paused if the error is [warning or lower](https://github.com/getsentry/getsentry/blob/b08907d9da3e8856c6cbedbd86d4a722c6f89dd9/gocd/templates/bash/backend/check-sentry-new-errors.sh#L12): ``` --additional-query="issue.type:error !level:info !level:warning" ``` Rendering of a warning-level exception: <img width="265" alt="image" src="https://github.com/user-attachments/assets/cd630c9b-9ac7-4894-aa33-736789c17c0b">
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Aug 27, 2024
| @@ -427,7 +428,7 @@ def _populate_trees_process_error(self, error: ApiError, extra: dict[str, str]) | |||
| else: | |||
| # We do not raise the exception so we can keep iterating through the repos. | |||
| # Nevertheless, investigate the error to determine if we should abort the processing | |||
| logger.error("Continuing execution. Investigate: %s", error_message, extra=extra) | |||
| capture_message("Continuing execution. Investigate: %s", error_message, extra=extra) | |||
There was a problem hiding this comment.
In the original PR it used to be this:
I'm removing level="warning" since it is not accepted.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76616 +/- ##
=======================================
Coverage 78.16% 78.17%
=======================================
Files 6901 6902 +1
Lines 307014 306988 -26
Branches 52875 52848 -27
=======================================
+ Hits 239987 239991 +4
+ Misses 60608 60597 -11
+ Partials 6419 6400 -19 |
snigdhas
approved these changes
Aug 28, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
armenzg
added a commit
that referenced
this pull request
Aug 29, 2024
Fixes issue introduced in #76616.
armenzg
added a commit
that referenced
this pull request
Aug 29, 2024
Fixes issue introduced in #76616.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reports the exceptions as warning-level errors rather than error-level.
Deployments do not get paused if the error is warning or lower:
Rendering of a warning-level exception:
PS: This is a redo of #76212 but without passing a level, thus, making it an info-level message.