perf(replay): reduce postgres queries in recording consumer using get_from_cache #77365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
aliu39
commented
Sep 11, 2024
aliu39
commented
Sep 11, 2024
JoshFerge
approved these changes
Sep 11, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77365 +/- ##
===========================================
- Coverage 88.40% 78.18% -10.22%
===========================================
Files 2998 6959 +3961
Lines 186451 308986 +122535
Branches 30634 50556 +19922
===========================================
+ Hits 164826 241590 +76764
- Misses 15602 60936 +45334
- Partials 6023 6460 +437 |
cmanallen
requested changes
Sep 12, 2024
cmanallen
reviewed
Sep 12, 2024
| @@ -294,8 +295,9 @@ def process_message(buffer: RecordingBuffer, message: bytes) -> None: | |||
| else None | |||
| ) | |||
|
|
|||
| project = Project.objects.get_from_cache(decoded_message["project_id"]) | |||
There was a problem hiding this comment.
How much memory will this consume?
There was a problem hiding this comment.
For the cache? I don't know. Got the inspiration from occurrence_consumer.py
There was a problem hiding this comment.
we already are usually caching the project for other places in ingest, so it probably won't be very much additional if any
cmanallen
requested changes
Sep 19, 2024
cmanallen
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmanallen pointed out the queries we make in _handle_breadcrumb, used to check feature flags and project options, could overload Postgres as we scale. To fix this we can do the query at the top-level and use
get_from_cache