-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sentry_apps): Move over installation endpoints to sentry_apps #77869
chore(sentry_apps): Move over installation endpoints to sentry_apps #77869
Conversation
❌ 8 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
assert isinstance(request.user, User) or isinstance( | ||
request.user, RpcUser | ||
), "user must be authenticated to create a SentryAppInstallation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this typing too narrow? -> are there other types of users (RpcUser, User, AnonymousUser)? Is it even true that being authenticated == being a User/RpcUser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there other types of users (RpcUser, User, AnonymousUser)?
No, those are all the type options for request.user
Is it even true that being authenticated == being a User/RpcUser.
Yes, if a request is not authenticated request.user
will be AnonymousUser
.
assert isinstance(request.user, User) or isinstance( | ||
request.user, RpcUser | ||
), "user must be authenticated to create a SentryAppInstallation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there other types of users (RpcUser, User, AnonymousUser)?
No, those are all the type options for request.user
Is it even true that being authenticated == being a User/RpcUser.
Yes, if a request is not authenticated request.user
will be AnonymousUser
.
src/sentry/sentry_apps/api/endpoints/sentry_app_installations.py
Outdated
Show resolved
Hide resolved
gyatt Co-authored-by: Mark Story <mark@mark-story.com>
migrate SentryAppInstallation related endpoints to sentry_apps!
[X] endpoints
[X] tests
[x] typing - 1 line
[] getsentry shim - N/A
issue ref(#73857)