fix(issue-views): Fixes unsaved changes not detected on reload #77892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tab with different query
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77892 +/- ##
==========================================
- Coverage 79.92% 77.99% -1.93%
==========================================
Files 7167 6996 -171
Lines 319795 310241 -9554
Branches 50763 50763
==========================================
- Hits 255582 241963 -13619
+ Misses 58460 56142 -2318
- Partials 5753 12136 +6383 |
malwilley
approved these changes
Sep 23, 2024
| @@ -289,7 +289,7 @@ function CustomViewsIssueListHeaderTabsContent({ | |||
| return; | |||
| } | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [navigate, organization.slug, query, sort, viewId]); | |||
| }, [navigate, organization.slug, query, sort, viewId, tabListState]); | |||
There was a problem hiding this comment.
This is a good example of the eslint rule trying to help us, would be good to take a second look at some point and see if we can remove the ignores
MichaelSun48
deleted the
msun/issueViews/fixNoUnsavedChangesOnReload
branch
harshithadurai
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fixes a uncommon bug where reloading the page on a tab where the query is not the tab's persistent query would not retrigger the unsaved changes icon. <details open> <summary>Before (notice how after the page refresh, the unsaved changes indicator is gone)</summary> https://github.com/user-attachments/assets/2f6f471f-27b0-431a-8a1a-357df65c2881 </details> <details> <summary>After </summary> https://github.com/user-attachments/assets/87c4b6a6-008e-4f65-b0b6-c6d891b54fb6 </details>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a uncommon bug where reloading the page on a tab where the query is not the tab's persistent query would not retrigger the unsaved changes icon.
Before (notice how after the page refresh, the unsaved changes indicator is gone)
Screen.Recording.2024-09-22.at.5.24.14.PM.mov
After
Screen.Recording.2024-09-22.at.5.29.00.PM.mov