Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-views): Fixes unsaved changes not detected on reload #77892

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(issue-views): Fixes unsaved changes not detected on reload #77892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/views/issueList/customViewsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ function CustomViewsIssueListHeaderTabsContent({

setDraggableTabs(
draggableTabs.map(tab =>
tab.key === selectedTab!.key
tab.key === selectedTab.key
? {
...tab,
unsavedChanges,
Expand Down Expand Up @@ -289,7 +289,7 @@ function CustomViewsIssueListHeaderTabsContent({
return;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [navigate, organization.slug, query, sort, viewId]);
}, [navigate, organization.slug, query, sort, viewId, tabListState]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good example of the eslint rule trying to help us, would be good to take a second look at some point and see if we can remove the ignores


// Update local tabs when new views are received from mutation request
useEffect(() => {
Expand Down
Loading