fix: Re-add QueuingMetricSink to cadence setup #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently seeing only a handful of metrics being emitted and it might be due to that.
lynnagara
approved these changes
Jan 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5300 +/- ##
=======================================
Coverage 90.73% 90.74%
=======================================
Files 879 879
Lines 42972 42972
Branches 288 288
=======================================
+ Hits 38991 38994 +3
+ Misses 3939 3936 -3
Partials 42 42 ☔ View full report in Codecov by Sentry. |
|
PR reverted: 2033bd2 |
getsentry-bot
added a commit
that referenced
this pull request
Jan 5, 2024
This reverts commit d449a68. Co-authored-by: untitaker <837573+untitaker@users.noreply.github.com>
|
this one was useless, reverting. the real bugfix is getsentry/statsdproxy#41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently seeing only a handful of metrics being emitted and it
might be due to that.