Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add QueuingMetricSink to cadence setup #5300

Merged
merged 2 commits into from
Jan 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rust_snuba/src/metrics/statsd.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use cadence::prelude::*;
use cadence::{MetricBuilder, MetricError, StatsdClient};
use cadence::{MetricBuilder, MetricError, QueuingMetricSink, StatsdClient};
use rust_arroyo::utils::metrics::Metrics as ArroyoMetrics;
use statsdproxy::cadence::StatsdProxyMetricSink;
use statsdproxy::config::AggregateMetricsConfig;
Expand Down Expand Up @@ -27,7 +27,9 @@ impl StatsDBackend {
AggregateMetrics::new(config, upstream)
});

let mut client_builder = StatsdClient::builder(prefix, aggregator_sink);
let queuing_sink = QueuingMetricSink::from(aggregator_sink);

let mut client_builder = StatsdClient::builder(prefix, queuing_sink);
for (k, v) in global_tags {
client_builder = client_builder.with_tag(k, v);
}
Expand Down
Loading