Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generic-metrics): Add support for subscriptions to gauges #5736

Merged
merged 5 commits into from
Apr 25, 2024
Merged

feat(generic-metrics): Add support for subscriptions to gauges #5736

merged 5 commits into from
Apr 25, 2024

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Apr 9, 2024 •
edited
Loading

Added the new topics and config changes necessary to run subscriptions locally.

Also ran the scheduler and executor locally.

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2354 tests with 1 failed, 2351 passed and 2 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
pytest

Test name:
tests.utils.streams.test_topics::test_valid_topics

Envs:
- default
 
Traceback (most recent call last):
  File ".../local/lib/python3.11....../site-packages/sentry_kafka_schemas/sentry_kafka_schemas.py", line 80, in get_topic
    with open(topic_path) as f:
         ^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '.../local/lib/python3.11.../sentry_kafka_schemas/topics/scheduled-subscriptions-generic-metrics-gauges.yaml'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File ".../utils/streams/test_topics.py", line 10, in test_valid_topics
    sentry_kafka_schemas.get_topic(
  File ".../local/lib/python3.11....../site-packages/sentry_kafka_schemas/sentry_kafka_schemas.py", line 83, in get_topic
    raise SchemaNotFound
sentry_kafka_schemas.sentry_kafka_schemas.SchemaNotFound

@ayirr7 ayirr7 changed the title wip: add gauges subscriptions feat(generic-metrics): Add support for subscriptions to gauges Apr 25, 2024
@ayirr7 ayirr7 marked this pull request as ready for review April 25, 2024 14:25
@ayirr7 ayirr7 requested a review from a team as a code owner April 25, 2024 14:25
@ayirr7 ayirr7 merged commit 27a539c into master Apr 25, 2024
29 checks passed
@ayirr7 ayirr7 deleted the add-gauge-subs branch April 25, 2024 23:16
@getsentry-bot
Copy link
Contributor

PR reverted: d0c5093

getsentry-bot added a commit that referenced this pull request Apr 26, 2024
@getsentry-bot @ayirr7
Revert "feat(generic-metrics): Add support for subscriptions to gauges (
d0c5093 
#5736)"

This reverts commit 27a539c.

Co-authored-by: ayirr7 <47572810+ayirr7@users.noreply.github.com>
@ayirr7 ayirr7 restored the add-gauge-subs branch May 10, 2024 20:47
@ayirr7 ayirr7 mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhars nikhars nikhars approved these changes

@john-z-yang john-z-yang john-z-yang approved these changes

Assignees
No one assigned
Labels
Trigger: Revert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayirr7 @getsentry-bot @john-z-yang @nikhars