feat(eap): implement backend for "what tag values exist" RPC #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
reviewed
Sep 13, 2024
Zylphrex
reviewed
Sep 13, 2024
snuba/web/rpc/trace_item_values.py
Outdated
Comment on lines
59
to
64
| # multiSearchAny has special treatment with ngram bloom filters | ||
| # https://clickhouse.com/docs/en/engines/table-engines/mergetree-family/mergetree#functions-support | ||
| f.multiSearchAny( | ||
| column("attr_value"), | ||
| literals_array(None, [literal(request.value_substring_match)]), | ||
| ), |
There was a problem hiding this comment.
Not sure what happens when request.value_substring_match is empty but when that happens we should just return any result. Perhaps this condition can be optional
There was a problem hiding this comment.
if it's empty this condition is a no-op since every string contains the empty string
phacops
approved these changes
Sep 17, 2024
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
phacops
approved these changes
Sep 17, 2024
volokluev
approved these changes
Sep 17, 2024
Zylphrex
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 27, 2024
This uses RPC calls to fetch tag values from eap spans. depends on getsentry/snuba#6304 --------- Co-authored-by: William Mak <william@wmak.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have spans with tags like "hello": "world" and "hello": "blah", you'd like to be able to say 'what values are possible for key="hello"?'
This endpoint implements that functionality.